Reviews:MathieuDAquin about DisjointnessOfComplement (DOC)

{{#reviewabout:Submissions:DisjointnessOfComplement (DOC)|}}

MathieuDAquin about DisjointnessOfComplement (DOC) (Revision ID: (DOC)?oldid=5716 5716)

Overall suggestion (score): 0 - needs major revision

Review Summary: I am not really sure what to do here.

What is proposed is an anti-pattern: a pattern which is sometimes used improperly and should, in these cases, be replaced by another. As far as I can tell, the portal is not intended to be used for such patterns. in addition, many elements are missing.

It could be interesting to discuss anti-pattern and whether the proposed ones are good, what should be the description of such patterns, etc.

Reviewer Confidence: OK

Problems: This does not fit the usual design patterns which are meant to be reused, but correspond to a pattern that should not be reused in cases where it is does not express the intended meaning. In addition, I am not actually convinced with the relation between the anti-pattern and the solution. The one to use is depends on what need to be expressed and I am not convinced that the one proposed corresponds to the one most often wrongly applied.

Community Relevance: As an anti-pattern, maybe.

Relation to Best Practices:

Reusability: The anti-pattern itself should not be reused. Sometimes the solution (replacement) should not be used either.

Relations to Other Patterns:

Overall Understandability: OK, except that most of the necessary is missing.

Clear Problem Description:

Clear Relevance and Consequences: Not really, as it is not explained how to detect where this anti-pattern applies (when it is used incorrectly). Not appropriate explanation of the consequences of using this one instead of the solution (can be easily understood for users familiar with DLs, but probably not by others).

Clear Figures and Illustrations: No.

Missing Information: It is not clear where this pattern comes from, what makes the authors think it is common, etc. See also "Clear Relevance and Consequences"

Posted: 2009/9/8 Last modified: 2009/09/8

All reviews | Add a comment at the bottom of this page