Reviews:MariaPoveda about OOPMetrics

Revision as of 07:04, 21 August 2012 by MariaPoveda (Talk | contribs)

(diff) ←Older revision | Current revision (diff) | Newer revision→ (diff)

MariaPoveda about OOPMetrics (Revision ID: 11161)

Overall suggestion (score): 0 - needs major revision

Review Summary: The patterns describes numerical values (float and integer) for onject-oriented software metrics.

The pattern is reusable and general enough.

There are some revisions needed.

Reviewer Confidence: High

Problems: Main comments:

.- The domain of the relationship "hasMetric" is set as the intersection of serveral classes, namely OOPClass, OOPProject, OOPMethod and OOPPackage. I think it should be defined as the union of theses classes so that if a instance holds this property it is not classified as instance of all these types, that might be disjoint, when running a reasoner over the ontology.

.- The CPAnnotation schema is not imported in the OWL building block as stated in the call. It would be great if the pattern were annotated using such a schema.

.- There are no labels nor comments in the OWL code.

Minor comments:

.- The already existing domain "software" should be added to the domains field.

.- The figure could be improved by including the datatype properties.

Community Relevance: Good

Relation to Best Practices:

Reusability: Good

Relations to Other Patterns:

Overall Understandability: Even though the understandability is good, it would be advisable to explain in more detail the solution description.

Clear Problem Description: Good

Clear Relevance and Consequences: Good

Clear Figures and Illustrations: The figure could be improved by including the datatype properties.

Missing Information: