Reviews:AndreaNuzzolese about Reactor pattern

Revision as of 18:12, 29 August 2012 by AndreaNuzzolese (Talk | contribs)

(diff) ←Older revision | Current revision (diff) | Newer revision→ (diff)

AndreaNuzzolese about Reactor pattern (Revision ID: pattern?oldid=11175 11175)

Overall suggestion (score): 1 - needs minor revision

Review Summary: The pattern addresses a relavant problem in modeling reactive processes. The problem statement and the solution presented and proposed by the author are clear. The terminology used for naming classes and properties is appropriate with respect to the context. Competency questions proposed are exhaustive for expressing the requirements that should be covered by the patterns.

In my opinion there is a lack of usage of existing content pattern. For example the ProcessParameter class can be defined by specializing the Parameter class from the parameter pattern (http://ontologydesignpatterns.org/cp/owl/parameter.owl). I also see an Event as a n-ary relation. This allows to express the Event class by specializing the Situation content pattern.

I don't understand the need of the definition of the description object property. If its intent is to express the descriptive context of a concept the Description pattern could be used. Otherwise an annotation property or even the rdfs:comment could be used.

I find the existential restriction for the Process class to strict for what is used as a top level class.

The author is encouraged to use labels and comments for entities defined in the pattern.

Reviewer Confidence: High

Problems: There is a typo in the hasEnvironemntalCondition object property that should be hasEnvironmentalCondition. Labels and comments should be defined for each class and property in the pattern.

Community Relevance: The relevance is high.

Relation to Best Practices: As described in the summary existing content patterns should be used by the Reactor pattern.

Reusability: The design adopted makes the pattern highly. The only remark is the existential restriction for the Process class, which in my opinion is to strict for a top level class in a pattern for representing general reactive processes.

Relations to Other Patterns: A similar pattern in the ODP repository is the reaction pattern.

Overall Understandability:

Clear Problem Description:

Clear Relevance and Consequences:

Clear Figures and Illustrations:

Missing Information: